[Asterisk-code-review] res pjsip outbound authenticator digest.c: Fix memory pool l... (asterisk[14])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4443 )

Change subject: res_pjsip_outbound_authenticator_digest.c: Fix memory pool leak.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4443/1/res/res_pjsip_outbound_authenticator_digest.c
File res/res_pjsip_outbound_authenticator_digest.c:

PS1, Line 117: 	if (set_outbound_authentication_credentials(&auth_sess, auths, challenge)) {
             : 		ast_log(LOG_WARNING, "Failed to set authentication credentials\n");
             : 		return -1;
             : 	}
It appears the you don't have to call 'deinit' in this off nominal path. However, I think a comment saying why would be prudent.


-- 
To view, visit https://gerrit.asterisk.org/4443
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4473141b8c3961d0dc91c382beb3876b3efb45c8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes