[Asterisk-code-review] pjsip/sdp offer answer: Noload the external codecs (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Mon Nov 14 09:40:40 CST 2016


Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4409 )

Change subject: pjsip/sdp_offer_answer:  Noload the external codecs
......................................................................


pjsip/sdp_offer_answer:  Noload the external codecs

The inclusion of the external codecs was altering the sdp and causing
the test to fail.  Unfortunately there's an asterisk bug that prevents
codecs with multiple formats from being negated in an endpoint's
"allow" parameter so the only way to remove the codecs is to noload
them.

Change-Id: Ic60ca229736340764746dfd1ed9c745d3e2e781e
---
A tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/configs/ast1/modules.conf.inc
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Matt Jordan: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved



diff --git a/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/configs/ast1/modules.conf.inc b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/configs/ast1/modules.conf.inc
new file mode 100644
index 0000000..85819d4
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/incoming/nominal/single-media-stream/audio/basic/configs/ast1/modules.conf.inc
@@ -0,0 +1,6 @@
+noload => codec_g729a.so
+noload => codec_opus.so
+noload => codec_silk.so
+noload => codec_siren7.so
+noload => codec_silk14.so
+

-- 
To view, visit https://gerrit.asterisk.org/4409
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic60ca229736340764746dfd1ed9c745d3e2e781e
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>



More information about the asterisk-code-review mailing list