[Asterisk-code-review] 1. Transmit Silence on ControlPlayback pause (ASTERISK-26562) (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4396 )

Change subject: 1. Transmit Silence on ControlPlayback pause (ASTERISK-26562)
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4396/2/main/app.c
File main/app.c:

PS2, Line 1178: 					if (silgen) {
              : 						ast_channel_stop_silence_generator(chan, silgen);
              : 					}
In the interest of symmetry, I recommend placing this outside the for loop. It makes it more clear to people reading the code that the silence generator is guaranteed to be stopped. It also is more future proof, just in case a new reason to break out of the for loop is added.


-- 
To view, visit https://gerrit.asterisk.org/4396
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6cb0ffc2b8c775639ce7784fe96f4ea00cfa2f8
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mikheili Dautashvili <mishadaut at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes