[Asterisk-code-review] app queue: new variable set when abandoned (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4323 )

Change subject: app_queue: new variable set when abandoned
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

https://gerrit.asterisk.org/#/c/4323/1/apps/app_queue.c
File apps/app_queue.c:

Line 4596: /*! \brief Record that a caller gave up on waiting in queue */
This needs to be documented and as a new feature is only eligible for inclusion into 13 and 14 if it includes a test. Otherwise it can go into master.


-- 
To view, visit https://gerrit.asterisk.org/4323
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4729af9bff4eba436d8a776afd3374065d0036d3
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-HasComments: Yes