[Asterisk-code-review] app queue: add new Service Level calculation (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change. ( https://gerrit.asterisk.org/4325 )

Change subject: app_queue: add new Service Level calculation
......................................................................


Patch Set 3:

> this should be covered by a test that should exists? if you check
 > the code is adding a new calculation on the same places the
 > previous service level calculation is just other formula adding SL2

So, first, no, there isn't a test that covers the service level calculations at all. Admittedly, the app_queue tests are limited in the testsuite.

Modifications that are a new feature - which this is - need to have tests. Modifications to app_queue in particular need tests, due to its tendency to break in new and creative ways.

Second, I think a better explanation of what this patch does, and why it is needed, is warranted. What does a "SL2" calculation provide over the existing service level calculations?

-- 
To view, visit https://gerrit.asterisk.org/4325
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0970c620460507cd9d45b0d43600779c8915e770
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Sebastian Gutierrez <scgm11 at gmail.com>
Gerrit-HasComments: No