[Asterisk-code-review] stasis recording/stored: remove calls to deprecated readdir ... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4224 )

Change subject: stasis_recording/stored: remove calls to deprecated readdir_r function.
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4224/4/tests/test_file.c
File tests/test_file.c:

Line 139: 	if (ast_file_read_dirs("/tmp", handle_find_file,
Wouldn't this iterate everything in /tmp?  If the goal is to perform a recursive search I think it would be better to create create a subdir within tmp_dir to hold the files and limit the search to tmp_dir.


-- 
To view, visit https://gerrit.asterisk.org/4224
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8f54689b1e2873e82a09d0d0d2faf41964e80ba
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes