[Asterisk-code-review] tests/apps/statsd: Correct minversion and dependencies (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Wed Nov 2 16:28:39 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/4282 )

Change subject: tests/apps/statsd:  Correct minversion and dependencies
......................................................................


tests/apps/statsd:  Correct minversion and dependencies

Changed the off-nominal tests' minversion from 13.7.0 to 14.0.0 since
app_statsd isn't available in 13.

Changed all statsd tests to require app_statsd.

Change-Id: I419406d4c74ad6823f31a766fd56a8264695de8b
---
M tests/apps/statsd/nominal/test-config.yaml
M tests/apps/statsd/off-nominal/empty_params/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
M tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
M tests/apps/statsd/off-nominal/no_metric/test-config.yaml
M tests/apps/statsd/off-nominal/no_value/test-config.yaml
M tests/apps/statsd/off-nominal/no_variable/test-config.yaml
9 files changed, 17 insertions(+), 8 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  Corey Farrell: Looks good to me, but someone else must approve



diff --git a/tests/apps/statsd/nominal/test-config.yaml b/tests/apps/statsd/nominal/test-config.yaml
index cec4f57..4f2653f 100644
--- a/tests/apps/statsd/nominal/test-config.yaml
+++ b/tests/apps/statsd/nominal/test-config.yaml
@@ -49,6 +49,7 @@
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/empty_params/test-config.yaml b/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
index 11309e9..ae53a63 100644
--- a/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/empty_params/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
index 7fa8582..987c50d 100644
--- a/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_metric/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
index a166e5b..7b0f20f 100644
--- a/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_sample_rate/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
index 0a0c00b..a49953f 100644
--- a/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_value/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml b/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
index 78a138e..ef5a8b1 100644
--- a/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/invalid_variable/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/no_metric/test-config.yaml b/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
index 375ba66..3216ad2 100644
--- a/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/no_metric/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/no_value/test-config.yaml b/tests/apps/statsd/off-nominal/no_value/test-config.yaml
index 65adce5..0ef2dcd 100644
--- a/tests/apps/statsd/off-nominal/no_value/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/no_value/test-config.yaml
@@ -36,11 +36,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps
diff --git a/tests/apps/statsd/off-nominal/no_variable/test-config.yaml b/tests/apps/statsd/off-nominal/no_variable/test-config.yaml
index 25ff9ec..5cfe4a6 100644
--- a/tests/apps/statsd/off-nominal/no_variable/test-config.yaml
+++ b/tests/apps/statsd/off-nominal/no_variable/test-config.yaml
@@ -38,11 +38,12 @@
     async: True
 
 properties:
-    minversion: '13.7.0'
+    minversion: '14.0.0'
     dependencies:
         - python: 'autobahn.websocket'
         - python: 'starpy'
         - python: 'twisted'
+        - asterisk: 'app_statsd'
     tags:
         - statsd
         - apps

-- 
To view, visit https://gerrit.asterisk.org/4282
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I419406d4c74ad6823f31a766fd56a8264695de8b
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list