[Asterisk-code-review] rtp engine: Allow more than 32 dynamic payload types. (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/3680 )

Change subject: rtp_engine: Allow more than 32 dynamic payload types.
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.asterisk.org/#/c/3680/7/main/rtp_engine.c
File main/rtp_engine.c:

Line 2332: 			for (x = MAX(ast_option_rtpptdynamic, 35); x < 77; ++x) {
Should this be x < 72?

Table 5 in section 6 of rfc 3551 has 72-76 reserved. From section 6: "The payload type range 72-76 is marked "reserved" so that RTCP and RTP packets can be reliably distinguished".


-- 
To view, visit https://gerrit.asterisk.org/3680
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes