[Asterisk-code-review] define PATH MAX for HURD (asterisk[14])

George Joseph asteriskteam at digium.com
Tue Nov 1 12:23:06 CDT 2016


George Joseph has uploaded a new change for review. ( https://gerrit.asterisk.org/4263 )

Change subject: define PATH_MAX for HURD
......................................................................

define PATH_MAX for HURD

PATH_MAX is not guaranteed to be defined. In parctice, all but the HURD
define it to a constant. It is indeed not safe to assume there won't be
longer paths and Asterisk generally does err safely on such cases.

So even for HURD we'll just pretend PATH_MAX is 4096.

ASTERISK-25070 #close

Change-Id: I53d10ba18c34c132bcb640a5fd8e0da1d9b22db3
---
M include/asterisk.h
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/63/4263/1

diff --git a/include/asterisk.h b/include/asterisk.h
index 93c7cfb..f3f8b3a 100644
--- a/include/asterisk.h
+++ b/include/asterisk.h
@@ -36,6 +36,15 @@
 #define AST_FILE_MODE 0666
 #endif
 
+/* Make sure PATH_MAX is defined on platforms (HURD) that don't define it.
+ * Also be sure to handle the case of a path larger than PATH_MAX
+ * (err safely) in the code.
+ */
+#ifndef PATH_MAX
+#define PATH_MAX 4096
+#endif
+
+
 #define DEFAULT_LANGUAGE "en"
 
 #define DEFAULT_SAMPLE_RATE 8000

-- 
To view, visit https://gerrit.asterisk.org/4263
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53d10ba18c34c132bcb640a5fd8e0da1d9b22db3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>



More information about the asterisk-code-review mailing list