[Asterisk-code-review] res/stasis: Add CLI commands for displaying/debugging ARI apps (asterisk[13])

Matt Jordan asteriskteam at digium.com
Tue Nov 1 09:06:28 CDT 2016


Matt Jordan has posted comments on this change. ( https://gerrit.asterisk.org/4164 )

Change subject: res/stasis: Add CLI commands for displaying/debugging ARI apps
......................................................................


Patch Set 3:

> > > Any thoughts on how we might have a CLI command, but not have
 > to
 > > 'turn on debugging' for each test?
 > >
 > > Issuing a cli command from the top level ari testsuite class to
 > > enable ari debugging may work. If that works then it would only
 > be
 > > a single change for all ari based tests.
 > >
 > > If that is not feasible another option would be to wrap the
 > > Asterisk debug message with a TEST_FRAMEWORK #ifdef
 > 
 > I think I'll go with that option, as that requires less updating of
 > all the tests.

I actually went with the macro constant 'AST_DEVMODE', as:
(a) That's used already in the same location for event validation
(b) In the case where you want event validation but are not running the test suite, having the event be dumped out to debug would be useful

-- 
To view, visit https://gerrit.asterisk.org/4164
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51ad6ff0cabee0d69db06858c13f18b1c513c9f5
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list