[Asterisk-code-review] core/dial: New channel variable FORWARDERNAME (asterisk[13])

Joshua Colp asteriskteam at digium.com
Tue May 31 05:15:01 CDT 2016


Joshua Colp has posted comments on this change.

Change subject: core/dial: New channel variable FORWARDERNAME
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

As this is a new feature it should also have a test to be included in 13.

https://gerrit.asterisk.org/#/c/2905/1/apps/app_dial.c
File apps/app_dial.c:

Line 837: 	char tmppeer[80];
This should use the AST_CHANNEL_NAME define.


-- 
To view, visit https://gerrit.asterisk.org/2905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34e93e8c1b5e17776a77b319703c48c8ca48e7b2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list