[Asterisk-code-review] res pjsip: improve realtime performance #2 (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: improve realtime performance #2
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2906/1/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 106: 			if (contact_status && contact_status->status != UNAVAILABLE) {
Why the Endpoint status is set to ONLINE if the Contact status is not UNAVAILABLE?

I think the correct way is 
- set ONLINE if Contact status is AVAILABLE.
- set OFFLINE if Contact status is UNAVAILABLE.
- set UNKNOWN in any other cases.


-- 
To view, visit https://gerrit.asterisk.org/2906
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id324c1776fa55d3741e0c5457ecac0304cb1a0df
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes