[Asterisk-code-review] bridge: Relax BackgroundDetect minimum audio. (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Thu May 26 15:51:34 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: bridge: Relax BackgroundDetect minimum audio.
......................................................................


bridge: Relax BackgroundDetect minimum audio.

When detecting audio using BackgroundDetect it is possible
for a re-invite to be received indicating media should be
sent to a different source and that it is coming from a
different source. In this case we will eat 3 RTP packets,
or 60ms of audio, for the probation period causing the
amount of audio received to be 18ms. As the configuration
requires 20ms it will be as if the other side never
spoke and the test will fail.

This change merely relaxes the minimum to be 15ms instead.

ASTERISK-26062 #close

Change-Id: I6b58887b6796a5e05f533c59184eb32323940ce4
---
M configs/bridge/ast2/extensions.conf
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/configs/bridge/ast2/extensions.conf b/configs/bridge/ast2/extensions.conf
index 570779f..0798aa9 100644
--- a/configs/bridge/ast2/extensions.conf
+++ b/configs/bridge/ast2/extensions.conf
@@ -9,7 +9,7 @@
 same => n,Record(alice_audio_%d.wav,,,k)
 same => n,UserEvent(Connected, Channel: ${CHANNEL(name)})
 same => n,Set(TALK_DETECTED=0)
-same => n,BackgroundDetect(${RECORDED_FILE},1,20,,20000)
+same => n,BackgroundDetect(${RECORDED_FILE},1,15,,20000)
 same => n,NoOp(TALK_DETECTED is ${TALK_DETECTED})
 same => n,GoToIf($[${TALK_DETECTED}=0]?talkdetectfail:talkdetectpass)
 same => n(talkdetectfail),NoOp()

-- 
To view, visit https://gerrit.asterisk.org/2907
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b58887b6796a5e05f533c59184eb32323940ce4
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list