[Asterisk-code-review] app voicemail: fix bugs, imap mm status log change to debug (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: app_voicemail: fix bugs, imap mm_status log change to debug
......................................................................


Patch Set 3:

(5 comments)

https://gerrit.asterisk.org/#/c/2883/1/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 2715: 		chan ? S_COR(ast_channel_caller(chan)->id.number.valid, ast_channel_caller(chan)->id.number.str, NULL) : NULL,
> More spacing on both lines...
Already fixed it in Patch Set 2


PS1, Line 2715: 		chan ? S_COR(ast_channel_caller(chan)->id.number.valid, ast_channel_caller(chan)->id.number.str, NULL) : NULL,
              : 		chan ? S_COR(ast_channel_caller(chan)->id.name.valid, ast_channel_caller(chan)->id.name.str, NULL) : N
> Need spaces around the '?' and ':' on both lines.
Already fixed it in Patch Set 2


https://gerrit.asterisk.org/#/c/2883/2/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 5191
> We shouldn't remove this flag on a release branch, IMHO.
I didn't find any usage of this flag.
It seems it's set but never used.
What's the reason to have this flag?


https://gerrit.asterisk.org/#/c/2883/3/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 5191
> It took awhile to find when this email header was added.  It was added in 4
I think it was added because it has in txt file.
But it's used.


PS3, Line 3265: 	ast_debug(5, " Mailbox %s", mailbox);
              : 	if (status->flags & SA_MESSAGES)
              : 		ast_debug(5, ", %lu messages", status->messages);
              : 	if (status->flags & SA_RECENT)
              : 		ast_debug(5, ", %lu recent", status->recent);
              : 	if (status->flags & SA_UNSEEN)
              : 		ast_debug(5, ", %lu unseen", status->unseen);
              : 	if (status->flags & SA_UIDVALIDITY)
              : 		ast_debug(5, ", %lu UID validity", status->uidvalidity);
              : 	if (status->flags & SA_UIDNEXT)
              : 		ast_debug(5, ", %lu next UID", status->uidnext);
              : 	ast_debug(5, "\n");
> There needs to be \n's on each ast_log and ast_debug message created.  The 
The function mm_status (like others mm_* functions) is called by UW-IMAP lib


-- 
To view, visit https://gerrit.asterisk.org/2883
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f83d88b69b36934e2539c114b9fb612deed971b
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes