[Asterisk-code-review] core/dial: New channel variable FORWARDERNAME (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: core/dial: New channel variable FORWARDERNAME
......................................................................


Patch Set 1:

> > Should we be using a channel variable for this or making the
 > > information available via the CHANNEL() dialplan function?
 > I did it the same as ATTENDEDTRANSFER and BLINDTRANSFER.
 > What channel should we use to add this variable?
 > When we are in FORWARD_CONTEXT the channel is LOCAL/<forward-to>@<FORWARD_CONTEXT>.
 > Should we use this LOCAL channel or source channel which does dial
 > attempt?
 > 
 > > My concern is that FORWARDERNAME could be in use by someone's
 > dialplan
 > > and this change would cause the value to be changed.
 > I added notice to CHANGES to warn a user about a new built-in
 > variable.

Why are you adding this channel variable?  What is the need for this channel variable?

-- 
To view, visit https://gerrit.asterisk.org/2905
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34e93e8c1b5e17776a77b319703c48c8ca48e7b2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No