[Asterisk-code-review] app voicemail: fix bugs, imap mm status log change to debug (asterisk[13])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: app_voicemail: fix bugs, imap mm_status log change to debug
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/2883/1/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 2715: 		chan ? S_COR(ast_channel_caller(chan)->id.number.valid, ast_channel_caller(chan)->id.number.str, NULL) : NULL,
More spacing on both lines...
chan ? S_COR.... : NULL


Line 11951: 			if (res < 0) {
This is a nit, but, spaces on variable assignment:
vms.starting = 1;


https://gerrit.asterisk.org/#/c/2883/2/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 5191
We shouldn't remove this flag on a release branch, IMHO.


-- 
To view, visit https://gerrit.asterisk.org/2883
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f83d88b69b36934e2539c114b9fb612deed971b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes