[Asterisk-code-review] res pjsip: add "via addr", "via port", "call id" to contact (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: add "via_addr", "via_port", "call_id" to contact
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2801/5/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 1171: 		ast_str_append(&buf, 0, "ViaAddress: %s:%d\r\n", contact->via_addr, contact->via_port);
pjproject doesn't provide a default for port and because port is an optional field for Via, this may be 0.  I think.

You'll have to suppress the ":0" in that case.  I wouldn't default it to 5060.


-- 
To view, visit https://gerrit.asterisk.org/2801
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36bcc0bf422b3e0623680152d80486aeafe4c576
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes