[Asterisk-code-review] threadpool: Fix potential data race. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: threadpool: Fix potential data race.
......................................................................


Patch Set 1:

The data race reported by the issue is a red-herring and not a real problem.  It can be safely ignored.  However, to shut up the stupid tool...

An alternate way that doesn't involve extra unlock calls:

worker_start()
{
  int is_zombie;

  lock
  while-loop {
  }
  is_zombie = worker->state == ZOMBIE
  unlock
  if (is_zombie) {
  }
}

-- 
To view, visit https://gerrit.asterisk.org/2900
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e33685a5c26fdb300851989a3b82be8c4e03781
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No