[Asterisk-code-review] app voicemail: fix bugs, imap mm status log change to debug (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Tue May 24 12:14:35 CDT 2016


Hello Anonymous Coward #1000019, Corey Farrell,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2883

to look at the new patch set (#2).

Change subject: app_voicemail: fix bugs, imap mm_status log change to debug
......................................................................

app_voicemail: fix bugs, imap mm_status log change to debug

Fixed some bugs:
- create dirpath when save downloading message from IMAP storage.
- create IMAP folder if not exists when saving to IMAP storage
- check if file successfully opened before write to it
- some IMAP checks
- remove non-standard flag 'Unseen'
etc

Change to debug IMAP mm_status log instead of verbose.

Remove unused X-Asterisk-VM-Caller-channel message header
for security reason. The clients should not know name of peer/endpoint.

ASTERISK-26045

Change-Id: I7f83d88b69b36934e2539c114b9fb612deed971b
---
M apps/app_voicemail.c
1 file changed, 144 insertions(+), 62 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/83/2883/2
-- 
To view, visit https://gerrit.asterisk.org/2883
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f83d88b69b36934e2539c114b9fb612deed971b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>



More information about the asterisk-code-review mailing list