[Asterisk-code-review] tests/channels/pjsip/publish: Fix double not in use PUBLISH ... (testsuite[master])

Anonymous Coward asteriskteam at digium.com
Tue May 24 11:12:14 CDT 2016


Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: tests/channels/pjsip/publish: Fix double not in use PUBLISH requests.
......................................................................


tests/channels/pjsip/publish: Fix double not in use PUBLISH requests.

This change disables the pbx_ael module to stop context merging.

Context merging is a problem because the result may be two
PUBLISH requests going out with a not in use state for the extension
state. Since the SIPp scenario files require a consistent number of
requests in a given order this throws them off and causes test failure.

No more should this happen!

In practice outside of tests the above behavior is actually perfectly
acceptable. The end result is that the published request still
reflects the current extension state.

Change-Id: Iafdf05f1a57e3fef5bcdb2ed004f1b76cd09499f
---
A tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
A tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
A tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
3 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  Corey Farrell: Looks good to me, but someone else must approve



diff --git a/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
new file mode 100644
index 0000000..2cd4d13
--- /dev/null
+++ b/tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/modules.conf.inc
@@ -0,0 +1 @@
+noload => pbx_ael.so
diff --git a/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
new file mode 100644
index 0000000..2cd4d13
--- /dev/null
+++ b/tests/channels/pjsip/publish/presence_pidf/configs/ast1/modules.conf.inc
@@ -0,0 +1 @@
+noload => pbx_ael.so
diff --git a/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc b/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
new file mode 100644
index 0000000..2cd4d13
--- /dev/null
+++ b/tests/channels/pjsip/publish/presence_xpidf/configs/ast1/modules.conf.inc
@@ -0,0 +1 @@
+noload => pbx_ael.so

-- 
To view, visit https://gerrit.asterisk.org/2899
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafdf05f1a57e3fef5bcdb2ed004f1b76cd09499f
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list