[Asterisk-code-review] tests/channels/pjsip/publish: Fix presence/dialog-info+xml t... (testsuite[master])

[Joshua Colp]

Hello Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2897

to look at the new patch set (#2).

Change subject: tests/channels/pjsip/publish: Fix presence/dialog-info+xml tests.
......................................................................

tests/channels/pjsip/publish: Fix presence/dialog-info+xml tests.

These tests when run on Jenkins exposed some race conditions
and behavior differences in how they run. This would cause the
tests to fail. These were also observed on other systems.

The first issue is that on some systems two PUBLISH requests may
be sent for the not in use state. This is because the custom device
state is set to not in use by default and we also set it to not
in use. Depending on the system this may or may not result in two
requests being sent. We now don't set it to not in use state
until all other states have been cycled through. This ensures that
only one initial not in use PUBLISH request goes out.

It was also observed that in some cases a state in between may
be skipped if changes were processed quickly. A delay has been
introduced to allow time for the PUBLISH request to get sent.

Change-Id: Ie12bc27e1f0f3df6204c4e92acb2e93096c067a4
---
M tests/channels/pjsip/publish/dialog_info_xml/configs/ast1/extensions.conf
M tests/channels/pjsip/publish/dialog_info_xml/sipp/publish.xml
M tests/channels/pjsip/publish/presence_pidf/configs/ast1/extensions.conf
M tests/channels/pjsip/publish/presence_pidf/sipp/publish.xml
M tests/channels/pjsip/publish/presence_xpidf/configs/ast1/extensions.conf
M tests/channels/pjsip/publish/presence_xpidf/sipp/publish.xml
6 files changed, 44 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/97/2897/2
-- 
To view, visit https://gerrit.asterisk.org/2897
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie12bc27e1f0f3df6204c4e92acb2e93096c067a4
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019