[Asterisk-code-review] Bridging: introduce "invisible" bridges. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Bridging: introduce "invisible" bridges.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2789/3/main/bridge.c
File main/bridge.c:

PS3, Line 4328: 	if (bridge && ast_test_flag(&bridge->feature_flags,
              : 			(AST_BRIDGE_FLAG_MASQUERADE_ONLY | AST_BRIDGE_FLAG_INVISIBLE))) {
This is OK for now.

This may bite us later in app_dial with real early bridges when doing a blonde transfer.  We'd be forced to do a masquerade even though the channel is in an invisible bridge.


-- 
To view, visit https://gerrit.asterisk.org/2789
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I804a209d3181d7c54e3d61a60eb462e7ce0e3670
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes