[Asterisk-code-review] configure: Avoid obsolete warnings on autoconf. (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: configure: Avoid obsolete warnings on autoconf.
......................................................................


Patch Set 1:

> > 1.  Copy the issue description and resolution to the commit
 > message.
 > 
 > Please, provide an example (or change the message yourself) because
 > yet I do not understand what you are looking for. 

Commit message guidelines are on the wiki here:

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


 > > Fedora 22-23, CentOS 6-7, Debian 6-7, Ubuntu 14-16, FreeBSD 9-10
 > [and] test wiht the --with-pjproject-bundled option on 13 and
 > master
 > 
 > Because I never used anything than Ubuntu, I cannot test this,
 > especially because I do not know what is ‘correct’. If nobody
 > cares, please, abandon this change.

 > > 1.  Copy the issue description and resolution to the commit
 > message.
 > 
 > Please, provide an example (or change the message yourself) because
 > yet I do not understand what you are looking for.
 > 
 > > Fedora 22-23, CentOS 6-7, Debian 6-7, Ubuntu 14-16, FreeBSD 9-10
 > [and] test wiht the --with-pjproject-bundled option on 13 and
 > master
 > 
 > Because I never used anything than Ubuntu, I cannot test this,
 > especially because I do not know what is ‘correct’. If nobody
 > cares, please, abandon this change.

Please keep in mind that you're removing options that autoconf has determined are obsolete on your system. While that may be beneficial for you - and probably for a number of other people - George's point of making sure that these options really are well and truly obsolete on a number of systems is a good one. As the person proposing the patch, it is up to you to either (a) test the changes out on a variety of well known and well used platforms (which George listed out), or (b) at a minimum provide analysis of each of the obsolete options that were removed and what their probable impact would be.

It's always good to keep in mind that people deploy Asterisk on a wide variety of platforms - even some slightly odd ones! - and it's good to be careful and not break them midstream.

-- 
To view, visit https://gerrit.asterisk.org/2885
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4512b40a1087a6cc2d90b461ccfd33a9ca4906e3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No