[Asterisk-code-review] Expand the scope of Dial Events (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Expand the scope of Dial Events
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2791/1/main/bridge_channel.c
File main/bridge_channel.c:

Line 2441: 			ast_channel_publish_dial(NULL, bridge_channel->chan, NULL, controls[frame->subclass.integer]);
> To answer your question, no I don't believe so. I think the side effect her
I don't think there are other side effects.  The DTMF atxfer does not generate the DialBegin/DialEnd events.  With these changes it will now generate the intermediate DialState events.


Line 2442: 			ast_bridge_channel_kick(bridge_channel, 0);
Kicking the busy/congested channel here is a new behaviour that shouldn't be necessary.


-- 
To view, visit https://gerrit.asterisk.org/2791
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42cbec7730d84640a434d143a0d172a740995543
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes