[Asterisk-code-review] ARI: Re-implement the ARI dial command, allowing for early b... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Re-implement the ARI dial command, allowing for early bridging.
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/2790/4/res/stasis/control.c
File res/stasis/control.c:

PS4, Line 862: 	if (shutting_down) {
             : 		return NULL;
Forgot to unlock


Line 868: 		return ao2_bump(dial_bridge);
Since you are protecting shutdown access with the dial_bridge_lock, you need to bump dial_bridge inside the lock's protection.

It might be better to have a common return point for returning the bridge ref in this case.


Line 878: 	return ao2_bump(dial_bridge);
same here


Line 1464: 	ao2_cleanup(dial_bridge);
set dial_bridge = NULL to ensure that we get a crash if trying to use it after shutdown.


-- 
To view, visit https://gerrit.asterisk.org/2790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7750359ddf45fcd45eaec749c5b3822de4a8ddbb
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes