[Asterisk-code-review] Expand the scope of Dial Events (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Expand the scope of Dial Events
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/2791/1/main/bridge_channel.c
File main/bridge_channel.c:

Line 2441: 			ast_channel_publish_dial(NULL, bridge_channel->chan, NULL, controls[frame->subclass.integer]);
> I think publishing the forwarding, busy, congestion, etc events is going to
To answer your question, no I don't believe so. I think the side effect here is that where it was not previously publishing dialing events during a DTMF attended transfer, it now will. Did you have ideas for other potential side effects it would have?


https://gerrit.asterisk.org/#/c/2791/1/main/cdr.c
File main/cdr.c:

PS1, Line 1907: 	return (strcmp(dialstatus, "RINGING") &&
              : 			strcmp(dialstatus, "PROCEEDING") &&
              : 			strcmp(dialstatus, "PROGRESS"));
> Should look for a positive dial end status like CANCEL or ANSWER rather tha
I'm going to disagree with you here. There are more possible concluding states for dialing than there are intermediate states. The reason I did it this way was because it was easy to enumerate the intermediate dialing states. Trying to scour the code for each type of ending dial state seemed likely for me to miss something.


https://gerrit.asterisk.org/#/c/2791/1/main/manager_channels.c
File main/manager_channels.c:

PS1, Line 1066: 	return (strcmp(dialstatus, "RINGING") &&
              : 			strcmp(dialstatus, "PROCEEDING") &&
              : 			strcmp(dialstatus, "PROGRESS"));
> same here about process of elimination
See my previous reply.


-- 
To view, visit https://gerrit.asterisk.org/2791
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42cbec7730d84640a434d143a0d172a740995543
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes