[Asterisk-code-review] ARI: Re-implement the ARI dial command, allowing for early b... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: ARI: Re-implement the ARI dial command, allowing for early bridging.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2790/1/res/stasis/control.c
File res/stasis/control.c:

Line 340: static int app_control_continue(struct stasis_app_control *control,
> This gives us the interesting possibility of continuing a channel in the di
There are likely several ARI commands that fall into the category of "You shouldn't be able to do this on a channel that is not up yet".

For instance, trying to play media to a down channel or ringing channel falls into this category. Continuing in the dialplan, as you have pointed out, also shouldn't happen.

I think what I'm going to do is to create a separate issue to audit ARI commands and make them respond with a 409 Conflict response if it does not make sense to be performing the action on a channel in the channel's current state.


-- 
To view, visit https://gerrit.asterisk.org/2790
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7750359ddf45fcd45eaec749c5b3822de4a8ddbb
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes