[Asterisk-code-review] res pjsip outbound publish: Ref leak in off nominal callback... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip_outbound_publish: Ref leak in off nominal callback paths
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2804/1/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

Line 871: #define DESTROY_CLIENT() do {			   \
> Why not just do this in sip_outbound_publish_client_destroy?
Because the outbound publish client object isn't necessarily being destroyed here, but we do need to destroy the client's client (which is the actual pjsip publishing object).


-- 
To view, visit https://gerrit.asterisk.org/2804
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I485d0bc9335090f373026f77c548042e258461df
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes