[Asterisk-code-review] res pjsip outbound publishing: After unloading the library w... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip_outbound_publishing: After unloading the library won't load again
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2805/1/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

Line 1217: 		ast_sorcery_object_unregister(ast_sip_get_sorcery(), "outbound-publish");
> Shouldn't this be outside the "else"?  Otherwise the module won't be able t
No, by putting it within the "else" it guarantees that the sorcery object type is only unregistered if the module is actually being unloaded.

By placing it outside the "else" it would be possible that the module fails to unload, but then the sorcery object type would also unregister leaving the still loaded module without its configuration sorcery object type registered.


-- 
To view, visit https://gerrit.asterisk.org/2805
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdc25e94e4cd40bc5a19eb4d0a00b86c2e9fedc9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes