[Asterisk-code-review] Unpausing of wrap-up should grant grace time. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: Unpausing of wrap-up should grant grace time.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

This should also be squashed into the original review which implements the feature.

https://gerrit.asterisk.org/#/c/2865/1/apps/app_queue.c
File apps/app_queue.c:

Line 1361: static char *wrap_up = "wrap-up";
Why the use of a static char here?


Line 6174: 		if (!set_member_paused( (char *) NULL, queue_data->member->interface, wrap_up, 1)) {
You don't need to cast NULL in here.


Line 7190: 		 * reset lastcall after a wrap-up pause to give a grace 
Redness


-- 
To view, visit https://gerrit.asterisk.org/2865
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1119dd490c17429741d6974550da34d266c066f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Troy Bowman <troy at lump.net>
Gerrit-HasComments: Yes