[Asterisk-code-review] contrib: Add a systemd service (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: contrib: Add a systemd service
......................................................................


Patch Set 2:

> Thanks for your comments.
 > 
 > Installing it is generally harmless on systems that don't have it
 > (except you now have an extra file). /etc/systemd may be a
 > preferred path to install if this is not part of a package, though.
 > What do you think?

/etc/systemd/system would be my preference but still, don't create that directory if it doesn't exist.  It's a simple enough test.

Actually, now that I think about it, you should install only the service file or the rc init file, not both.  I just tried this on my centos system and it created the /usr/lib/systemd/system directory, copied the service file, and also installed /etc/init.d/asterisk and enabled it.

 > 
 > Also: what's the point in Type=simple? Looking at my system, I see
 > it's not so common.

It's not common because most services are started as daemons which would require "Type=forking".  Since you pass the -f flag to asterisk telling it to run in the foreground, the type should be "simple".  That's the default if you don't specify a Type but its still better to explicitly specify it just for clarity.

-- 
To view, visit https://gerrit.asterisk.org/2844
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifde5d054ea0ba23d833e28ba80a6105d80070bc6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-HasComments: No