[Asterisk-code-review] basic-cfg: asterisk.conf: don't set languages (asterisk[master])

Joshua Colp asteriskteam at digium.com
Fri May 13 04:53:40 CDT 2016


Joshua Colp has submitted this change and it was merged.

Change subject: basic-cfg: asterisk.conf: don't set languages
......................................................................


basic-cfg: asterisk.conf: don't set languages

* No need to set language in a miniml configuration. 'en' will do just
  fine.
* It would be useful to have an example of setting it to a different
  language.
* Setting the documentation language explicitly is likewise not
  required. Setting it to a different value is not common. At least
  until there is a set of translated documentation.

Change-Id: I94d91ea34e129925f25af81ef8dc0906fb568cb7
Signed-off-by: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
---
M configs/basic-pbx/asterisk.conf
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Mark Michelson: Looks good to me, approved
  Joshua Colp: Looks good to me, but someone else must approve; Verified



diff --git a/configs/basic-pbx/asterisk.conf b/configs/basic-pbx/asterisk.conf
index d081265..ff66cee 100644
--- a/configs/basic-pbx/asterisk.conf
+++ b/configs/basic-pbx/asterisk.conf
@@ -10,5 +10,4 @@
 ;runuser = asterisk		; The user to run as. The default is root.
 ;rungroup = asterisk		; The group to run as. The default is root
 
-defaultlanguage = en
-documentation_language = en_US
+;defaultlanguage = es

-- 
To view, visit https://gerrit.asterisk.org/2795
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94d91ea34e129925f25af81ef8dc0906fb568cb7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list