[Asterisk-code-review] logger: Add PID to syslog messages. (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Thu May 12 17:32:02 CDT 2016


Kevin Harwell has posted comments on this change.

Change subject: logger: Add PID to syslog messages.
......................................................................


Patch Set 2: Code-Review-1

According to the following issue (and its associated patch):

https://issues.asterisk.org/jira/browse/ASTERISK-25407
Asterisk 11 commit 29694eb2aaa45c366fe28777722b0307f3742f95

The call to openlog was removed "due to the fact that the final call to openlog() in make_log_channel() supersedes the previous calls", whereas before it would only log to the last configured syslog.

Won't adding this back in break again what the previous code was trying to fix? Adding back the call to openlog, has it been tested to see if it once again only logs to the last configured syslog?

-- 
To view, visit https://gerrit.asterisk.org/2774
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2d43b0652e59b7ac319a7dba94501540d70ba36
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list