[Asterisk-code-review] res pjsip: Endpoint IP Access Controls (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip: Endpoint IP Access Controls
......................................................................


Patch Set 13:

(2 comments)

Matt,
It's not a new feature.
This feature exists in old SIP, but missing in PJSIP.

https://gerrit.asterisk.org/#/c/2551/4/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

PS4, Line 405: 	int64_t ms = ast_tvdiff_ms(ast_tvnow(), unid->first_seen);
             : 
             : 	ao2_wrlock(unid);
             : 	unid->count++;
> I disagree with this change. Requests coming in without an endpoint should 
May be better to log OPTIONS/NOTIFY as DEBUG instead of NOTICE


PS4, Line 518: 	if (!contact || contact->star) {
             : 		*addrs = NULL;
             : 		return 0;
             : 	}
             : 	if (!PJSIP_URI_SCHEME_IS_SIP(contact->uri) && !PJSIP_URI_SCHEME_IS_SIPS(contact->uri)) {
             : 		*addrs = NULL;
             : 		return 0;
             : 	}
             : 	sip_uri = pjsip_uri_get_uri(contact->uri);
             : 	ast_copy_pj_str(host, &sip_uri->host, sizeof(host));
             : 	ret
> This is a substantial behavior change. Why was it done? What security event
What exactly do not you like about these changes?


-- 
To view, visit https://gerrit.asterisk.org/2551
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I456dea3909d929d413864fb347d28578415ebf02
Gerrit-PatchSet: 13
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes