[Asterisk-code-review] Bridging: introduce "invisible" bridges. (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Bridging: introduce "invisible" bridges.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2789/1/main/bridge.c
File main/bridge.c:

Line 762: 	if (!(flags & AST_BRIDGE_FLAG_INVISIBLE)) {
> you use ast_test_flag in the other places, why not here?
ast_test_flag is used on an ast_flags structure. The 'flags' variable here is a straight integer. bridge->feature_flags is an ast_flags structure, so ast_test_flag is appropriate there.


Line 798: 	if (!(flags & AST_BRIDGE_FLAG_INVISIBLE)) {
> ditto
Same reason here as well.


-- 
To view, visit https://gerrit.asterisk.org/2789
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I804a209d3181d7c54e3d61a60eb462e7ce0e3670
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes