[Asterisk-code-review] PJSIP: only send sips Contact header, if URI contains sips URI (asterisk[master])

George Joseph asteriskteam at digium.com
Wed May 11 09:31:49 CDT 2016


George Joseph has posted comments on this change.

Change subject: PJSIP: only send sips Contact header, if URI contains sips URI
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

I'm going to abandon my patch in favor of this simpler one but the commit message needs more detail.

Cherry pick this to 13 when you're done.

https://gerrit.asterisk.org/#/c/2799/1//COMMIT_MSG
Commit Message:

Line 7: PJSIP: only send sips Contact header, if URI contains sips URI
Add more detail.  See my commit message as an example.


Line 8: 
Need to add the ASTERISK tag and Reported-by.
ASTERISK-25990 #close
Reported-by: Sebastian Damm


-- 
To view, visit https://gerrit.asterisk.org/2799
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae57d6531ce940b5fc64d5cd2673e60db0f9ba2
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sebastian Damm <damm at sipgate.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sebastian Damm <damm at sipgate.de>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list