[Asterisk-code-review] res api/channels: Add test for channels/create and channels... (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: res_api/channels:  Add test for channels/create and channels/dial
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2779/2/tests/rest_api/channels/create_and_dial/test-config.yaml
File tests/rest_api/channels/create_and_dial/test-config.yaml:

PS2, Line 110:         ari-requests:
             :             -   method: 'post'
             :                 uri: 'channels/channel1/dial'
             :             -   method: 'post'
             :                 uri: 'channels/channel2/dial'
             :                 'caller': 'channel1'
Per review 2790, there is now another required parameter for the dial command in ARI. As the review exists right now, you would need to add a 'dialstring' parameter, and set it to the appropriate local channel location for each of these. It's possible that review feedback on 2790 will end up making this requirement go away, but for the time being, I'm just pointing out why it's probably not good to merge this test yet.


-- 
To view, visit https://gerrit.asterisk.org/2779
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20a9cc235ff0ade747846526d5c37167199870f4
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes