[Asterisk-code-review] voicemail: Add test for passwordlocation=spooldir (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Thu May 5 17:12:29 CDT 2016


Hello Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2711

to look at the new patch set (#3).

Change subject: voicemail: Add test for passwordlocation=spooldir
......................................................................

voicemail: Add test for passwordlocation=spooldir

Adds a test that changes a voicemail password when the option
passwordlocation=spooldir is set. The password verifies that
audio prompts are given for the options as expected and then
on shutdown the presence of secret.conf in the user's voicemail
box folder is checked and verified to contain the expected
password.

The patch also adds a small improvement to
check_voicemail_options_change_password so that it can be ran
stand-alone without the user having to create
/tmp/asterisk-testsuite prior to running the test.

ASTERISK-25917
Reported-by: Jonathan Rose

Change-Id: I996c279e98efffe18bc6df55a395490256d560b1
---
M tests/apps/voicemail/check_voicemail_options_change_password/run-test
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast1/extensions.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast1/sip.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast1/voicemail.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast2/extensions.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/configs/ast2/sip.conf
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/run-test
A tests/apps/voicemail/check_voicemail_options_change_password_spooldir/test-config.yaml
M tests/apps/voicemail/tests.yaml
9 files changed, 425 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/11/2711/3
-- 
To view, visit https://gerrit.asterisk.org/2711
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I996c279e98efffe18bc6df55a395490256d560b1
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list