[Asterisk-code-review] res pjsip outbound publish: Add multi-user support per confi... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip_outbound_publish: Add multi-user support per configuration
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/#/c/2709/3/res/res_pjsip_outbound_publish.c
File res/res_pjsip_outbound_publish.c:

PS3, Line 153: 	char *user;
> You can optimize this by allocating both the user and transport name as par
Actually it appears there is no reason the transport name even needs to be in this object. Since there is a way back to the publish object it can get it from there, so I'll just do this for the user alone.


PS3, Line 155: 	struct ast_sip_outbound_publish_client *owner;
> Does this create a circular reference at all?
Yes, but it gets handled properly during teardown of the various objects during unpublishing. Per your other suggestion I added some more comments to the code explaining.


-- 
To view, visit https://gerrit.asterisk.org/2709
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88dde024cc83c916424645d4f5bb84a0fa936cc
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes