[Asterisk-code-review] file: Ensure nativeformats remains valid for lifetime of use. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: file: Ensure nativeformats remains valid for lifetime of use.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2762/1/main/file.c
File main/file.c:

PS1, Line 1148: 	ast_channel_lock(chan);
              : 	ast_verb(3, "<%s> Playing '%s.%s' (language '%s')\n", ast_channel_name(chan), filename, ast_format_get_name(ast_channel_writeformat(chan)), preflang ? preflang : "default");
              : 	ast_channel_unlock(chan);
Since this is a verbose message most of the time it won't be executed. If possible, check the log level prior to locking so it's not locking/unlocking for no reason.


-- 
To view, visit https://gerrit.asterisk.org/2762
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie45b65475e1481ddf05b874ee48f63e39fff8915
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes