[Asterisk-code-review] res pjsip: improve realtime performance (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip: improve realtime performance
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

With this patch, existing dynamic/persisted contacts aren't qualified on startup.  Register a phone then restart Asterisk.  You'll see that the contact is left in Unknown status until the phone re-registers.

https://gerrit.asterisk.org/#/c/2622/8/contrib/ast-db-manage/config/versions/837aa67461fb_ps_contacts_add_authenticate_qualify.py
File contrib/ast-db-manage/config/versions/837aa67461fb_ps_contacts_add_authenticate_qualify.py:

Line 1: """ps_contacts add authenticate_qualify
There's conflict now because other alembic stuff went in ahead of this.  You'll need to repoint revises and down_revision to the new head.


https://gerrit.asterisk.org/#/c/2622/8/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

Line 1062: static int qualify_and_schedule_c(void *obj, void *arg, int flags)
Can you rename the callbacks so they're a little more descriptive?   Maybe qualify_and_schedule_cb_with_aor and qualify_and_schedule_cb_without_aor.


-- 
To view, visit https://gerrit.asterisk.org/2622
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1831fa46c4578eae5a3e574ee3362fddf08a1f05
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes