[Asterisk-code-review] app voicemail: always copy dynamic struct to avoid race cond... (asterisk[13])

Matt Jordan asteriskteam at digium.com
Tue May 3 06:56:46 CDT 2016


Matt Jordan has posted comments on this change.

Change subject: app_voicemail: always copy dynamic struct to avoid race condition
......................................................................


Patch Set 13:

> Moving the freeing of the structure fields to before the values of
 > the voicemail user in the list are copied to the new/temporary
 > structure. We were freeing the values from the persistent
 > structure.

Doh!

-- 
To view, visit https://gerrit.asterisk.org/2433
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0643813116da84e2617291903d0d489b7425fb
Gerrit-PatchSet: 13
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: ibercom <ibercom123 at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list