[Asterisk-code-review] app voicemail: always copy dynamic struct to avoid race cond... (asterisk[13])

ibercom asteriskteam at digium.com
Tue May 3 05:39:13 CDT 2016


ibercom has posted comments on this change.

Change subject: app_voicemail: always copy dynamic struct to avoid race condition
......................................................................


Patch Set 13:

(3 comments)

https://gerrit.asterisk.org/#/c/2433/13/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 12330: static int vm_box_exists(struct ast_channel *chan, const char *data) 
why not delete adjacent red blobs ?


Line 15075: 				
why not delete adjacent red blobs ?


Line 15092: 		} 
why not delete adjacent red blobs ?


-- 
To view, visit https://gerrit.asterisk.org/2433
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0643813116da84e2617291903d0d489b7425fb
Gerrit-PatchSet: 13
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Andrew Nagy <andrew.nagy at the159.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: ibercom <ibercom123 at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list