[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Jaco Kroon]

Jaco Kroon has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for supporting codex.
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/1820/10/main/translate.c
File main/translate.c:

Line 565: 		if (current->seqno != path->f.seqno && path->f.seqno < 0x10000) {
> Ah, framein updates the seqno on the path.
Ah, checking that this is off-by-one anyway, the != is designed to try and not run this code for every packet, however, unless we receive duplicated frames the above will always be true for all but the first received frame.

And the code below will inject one too many empty frames always (unlike the previous patch from Alexander which did the correct -1 when calculating the number of frames to inject.


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes