[Asterisk-code-review] res pjsip exten state: Create PUBLISH messages. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change.

Change subject: res_pjsip_exten_state: Create PUBLISH messages.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2733/2/res/res_pjsip_exten_state.c
File res/res_pjsip_exten_state.c:

Line 577: 	if (!pub_data) {
Probably a minor detail, but should we be more vocal in cases of memory allocation failure?


-- 
To view, visit https://gerrit.asterisk.org/2733
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0dab4022f5cf59302129483ed38398764ee3cca
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes