[Asterisk-code-review] pbx: Add support for autohints. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: pbx: Add support for autohints.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2499/1/main/pbx.c
File main/pbx.c:

Line 3590: 	/* We only want actual devices for autohint functionality */
> Why is this? Why wouldn't you want to have autohints for virtual devices as
It creates extremely weirdly named hints as there are some very creative ones. I also didn't think it'd be that useful in practice. I can remove it though.


-- 
To view, visit https://gerrit.asterisk.org/2499
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e444c7da41b7b7d33374420fec658beeb18584e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: Yes