[Asterisk-code-review] ARI: Add method to create a new channel. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: ARI: Add method to create a new channel.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2513/1/res/ari/resource_channels.c
File res/ari/resource_channels.c:

Line 1470: static void chan_data_destroy(struct ari_channel_thread_data *chan_data)
Leaking chan_data itself
ast_free(chan_data);


PS1, Line 1553: 	ao2_cleanup(request_cap);
              : 	if (!chan_data->chan) {
You can simply do an ast_channel_cleanup(originator) here and eliminate the originator RAII_VAR().


-- 
To view, visit https://gerrit.asterisk.org/2513
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c96a0aba914b08e39f6256371a5bd4c92cbded8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes