[Asterisk-code-review] res stasis: Fix crash on a hanging up channel. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_stasis: Fix crash on a hanging up channel.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2508/1/res/stasis/control.c
File res/stasis/control.c:

Line 798: static int app_control_silence_stop(struct stasis_app_control *control,
> How about a comment that chan and data are left for ABI purposes.  A corres
There is no ABI issue here.  The function is private to this compilation unit.  You get a compiler error if you remove those parameters.  This is a callback function passed into stasis_app_send_command_async().  The callback function requires those parameters even if they are not used.


-- 
To view, visit https://gerrit.asterisk.org/2508
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21728161b5fe638cef7976fa36a605043a7497e4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes