[Asterisk-code-review] res rtp asterisk: Use separate SRTP session for RTCP with DTLS (asterisk[13])

[Joshua Colp]

Hello Mark Michelson, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2468

to look at the new patch set (#3).

Change subject: res_rtp_asterisk: Use separate SRTP session for RTCP with DTLS
......................................................................

res_rtp_asterisk: Use separate SRTP session for RTCP with DTLS

Asterisk uses separate UDP ports for RTP and RTCP traffic and RFC 5764
explicitly states:

  There MUST be a separate DTLS-SRTP session for each distinct pair of
  source and destination ports used by a media session

This means RTP keying material cannot be used for DTLS RTCP, which was
the reason why RTCP encryption would fail.

ASTERISK-25642

Change-Id: I7e8779d8b63e371088081bb113131361b2847e3a
---
M include/asterisk/rtp_engine.h
M main/rtp_engine.c
M main/sdp_srtp.c
M res/res_rtp_asterisk.c
4 files changed, 42 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/68/2468/3
-- 
To view, visit https://gerrit.asterisk.org/2468
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7e8779d8b63e371088081bb113131361b2847e3a
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Jacek Konieczny <jkonieczny at eggsoft.pl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Jacek Konieczny <jkonieczny at eggsoft.pl>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>