[Asterisk-code-review] Use separate SRTP session for RTCP with DTLS (asterisk[13])

[Jacek Konieczny]

Jacek Konieczny has posted comments on this change.

Change subject: Use separate SRTP session for RTCP with DTLS
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/2468/1/main/rtp_engine.c
File main/rtp_engine.c:

Line 1580: 	struct ast_srtp **srtp;
> Realy poiner of pointers?
Pointer to a pointer – that is what is needed for res_srtp->create() and res_srtp->replace(). Though, I was wondering if I should make it evident in the variable name, but I have not seen such a convention in Asterisk code.


-- 
To view, visit https://gerrit.asterisk.org/2468
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8779d8b63e371088081bb113131361b2847e3a
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Jacek Konieczny <jkonieczny at eggsoft.pl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Jacek Konieczny <jkonieczny at eggsoft.pl>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes